-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNIT] Final review of Unit 2.1 on smolagents - release 25/2/25 #195
Conversation
Co-authored-by: burtenshaw <[email protected]>
Co-authored-by: burtenshaw <[email protected]>
Co-authored-by: burtenshaw <[email protected]>
Co-authored-by: burtenshaw <[email protected]>
Co-authored-by: burtenshaw <[email protected]>
Co-authored-by: burtenshaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all congratulations on making this huge unit 2.1 @sergiopaniego. The content is simply excellent.
Most of my review was not on the content directly but on avoiding big block of text by adding bold and spaces.
But I kept your writing style, even if it’s different from unit 1, your style is excellent. It’s super smooth, easy to read, super well explained, focused on the student so yeah simply excellent (where have you been when I was writing deep rl course 🤣).
Feel free to refuse the suggestions you think are not relevant.
I have some changes asked though:
- I saw you put notebooks, I didn’t reviewed them yet (I’m doing this afternoon but I think we should add the links in the sections. An open with colab link.
- I'm creating a short conclusion. Feel free to change the content.
Co-authored-by: Thomas Simonini <[email protected]>
This PR is to review the final changes for the unit on the smolagents library.
Prose to review @pcuenca @simoninithomas @davidberenstein1957
Outstanding work for other PRs