Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNIT] Final review of Unit 2.1 on smolagents - release 25/2/25 #195

Merged
150 commits merged into from
Feb 21, 2025

Conversation

burtenshaw
Copy link
Collaborator

@burtenshaw burtenshaw commented Feb 19, 2025

This PR is to review the final changes for the unit on the smolagents library.

Prose to review @pcuenca @simoninithomas @davidberenstein1957

  • units/en/unit2/smolagents/code_agents.md
  • units/en/unit2/smolagents/introduction.md
  • units/en/unit2/smolagents/multi_agent_systems.md
  • units/en/unit2/smolagents/retrieval_agents.md
  • units/en/unit2/smolagents/tool_calling_agents.md
  • units/en/unit2/smolagents/tools.md
  • units/en/unit2/smolagents/why_use_smolagents.md

Outstanding work for other PRs

sergiopaniego and others added 30 commits January 30, 2025 19:55
Copy link
Member

@simoninithomas simoninithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all congratulations on making this huge unit 2.1 @sergiopaniego. The content is simply excellent.
Most of my review was not on the content directly but on avoiding big block of text by adding bold and spaces.

But I kept your writing style, even if it’s different from unit 1, your style is excellent. It’s super smooth, easy to read, super well explained, focused on the student so yeah simply excellent (where have you been when I was writing deep rl course 🤣).

Feel free to refuse the suggestions you think are not relevant.

I have some changes asked though:

  1. I saw you put notebooks, I didn’t reviewed them yet (I’m doing this afternoon but I think we should add the links in the sections. An open with colab link.
  2. I'm creating a short conclusion. Feel free to change the content.

@burtenshaw burtenshaw closed this pull request by merging all changes into main in ff6ae6f Feb 21, 2025
@burtenshaw burtenshaw deleted the unit_2_1_smolagents branch February 21, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants