-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: support copying token #97
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, nice feature!
Notice there're also some extra spaces on the top of color plate, could you fix them aligning with current version? Thanks
package.json
Outdated
@@ -26,4 +27,4 @@ | |||
"vitest": "^1.2.2" | |||
}, | |||
"packageManager": "[email protected]" | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's revert the unrelated changes and keep the file as it was
docs/app/live-editor.js
Outdated
@@ -126,6 +127,13 @@ export default function LiveEditor() { | |||
})) | |||
const debouncedTokenize = debouncedTokenizeRef.current | |||
|
|||
const customizableColorsString=useMemo(()=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to prettier the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share your Prettier configuration? My configuration should be different from yours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or it’s good to just leave the space between the operators like others. I didn’t prettify it but prefer the consistent code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that just now, do you see if there are any other issues?
Oh, thank you for offering so many suggestions, I will revise it! |
I get what you mean. |
@huozhi I just fixed the color plate issue. If you have time, you can check it out again ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the formatting issues, thanks for the PR!
For ease of use, I have supported the copying of the current color token in the document.