Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.13 to CI #57

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add 3.13 to CI #57

merged 1 commit into from
Aug 9, 2024

Conversation

hynek
Copy link
Owner

@hynek hynek commented Apr 16, 2024

We'll need a CFFI release first, though.

ref hynek/argon2-cffi#175

@hynek
Copy link
Owner Author

hynek commented Jul 25, 2024

I do not plan on merging as it is right now until we got a public 1.17.

There should be no changes necessary once they do they release.

@hynek hynek force-pushed the py313 branch 2 times, most recently from b0cd5eb to b6f87ce Compare August 1, 2024 15:28
@minrk
Copy link

minrk commented Aug 2, 2024

FWIW, free-threaded CPython 3.13 doesn't support the limited API, so to you'll need to set py_limited_api=False when sysconfig.get_config_var("Py_GIL_DISABLED"), both in setup.py and ffi.set_source, I believe, in order to get this package to install for cp313t builds.

CFFI doesn't officially support free-threaded Python yet, so perhaps not much reason to pursue it now. That said, I've successfully installed argon2-cffi with

and all tests argon2-cffi pass and Jupyter things run (arm64 mac). That isn't likely to exercise potential threadsafety issues, though.

@hynek
Copy link
Owner Author

hynek commented Aug 2, 2024

In principle, CFFI always release the GIL , so I hope that it’s gonna be just a matter of compilation flags. 😬

@hynek hynek merged commit 25b1a81 into main Aug 9, 2024
20 checks passed
@hynek hynek deleted the py313 branch August 9, 2024 05:47
@tacaswell
Copy link

I also needed python-cffi/cffi#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants