Add Ephemery command to documentation #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gconnect <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gconnect
changed the title
Signed-off-by: gconnect <[email protected]>
|
Thanks for this contribution @gconnect! I'll also review afterwards. |
Alright thanks for reviewing. I will be looking forward to your feedback. |
macfarla
reviewed
Nov 4, 2024
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Signed-off-by: gconnect <[email protected]>
|
LGTM from content POV just prob some formatting / linting to review @bgravenorst |
bgravenorst
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Looks good, thanks! All minor feedback :)
- We generally try and keep line lengths short
- We use the serial comma (I fixed these inline)
- It appears a table may be missing a pipe
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Co-authored-by: Byron Gravenorst <[email protected]> Signed-off-by: Glory Agatevure <[email protected]>
Signed-off-by: gconnect <[email protected]>
|
@bgravenorst I just made the requested changes. |
bgravenorst
approved these changes
Nov 4, 2024
Signed-off-by: Byron Gravenorst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add Ephemery commands to the following files:
Issue(s) fixed
Fixes #1726
Preview
https://besu-docs-git-fork-gconnect-add-documentatio-04d83e-hyperledger.vercel.app