PointCloudData reprojection into view CRS ('a la volee') #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
5 times, most recently
from
b696178 to
14ca5e0
Compare
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
from
14ca5e0 to
41b9727
Compare
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
5 times, most recently
from
e97a028 to
465f96e
Compare
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
17 times, most recently
from
48f7303 to
69f1099
Compare
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
from
69f1099 to
4e5819c
Compare
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
2 times, most recently
from
fc49f3f to
78f5c21
Compare
gchoqueux
reviewed
Feb 5, 2025
src/Parser/LASParser.js
Outdated
Comment on lines
158
to
162
| colorDepth: options.in?.colorDepth, | ||
| crsIn, | ||
| crsOut, | ||
| projDefs: { | ||
| [crsIn]: proj4.defs(crsIn), | ||
| [crsOut]: proj4.defs(crsOut), | ||
| }, |
There was a problem hiding this comment.
could you use the same structure in/out :
const options = {
in: {
crs: '....' // instead of crsIn
colorDepth: '...'
projDefs: '....'
},
out: {
crs: '....' // instead of crsOut
colorDepth: '...'
projDefs: '....'
}
}
}
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
7 times, most recently
from
d83c57e to
9a7d2d8
Compare
ftoromanoff
force-pushed
the
entwineAlaVolee
branch
from
9a7d2d8 to
83475f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the PR is to reproject 'a la volee' PopintCloudData (entwine, COPC , Potree1 and 2) data into the view crs.