Key id/develop #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created function and lists to capture the chords used in songfile (using regxs) and then put those into a dictionary. This will later be used to define the key.
changed order of creating the new transposed file, so that empty files wouldn't be created if there is a traceback earlier in the program
Added lists of notes and scales
Finished a basic key test that returns the key of the original file in a print statement. Also added a list of sus chords (not sus4). Also stripped trailing whitespace that appeared in the transposed song files (line 524) Added 'anothersong.txt' to use as another test of this program.
Updated key_test_final() docstring
Wrote a couple of lines to strip away the "/Y" part of "X/Y" chords. Plan to implement incorporation of these chords in transposing later. Also updated docstrings.
Added a function to test if minor chords are the most popular chord in the song. Updated regex for chords in keytest. Added comment for regex for X/Y chords.
updated docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key ID feature is in a working, if very rudimentary, state. I have also made some updates to other features of this program and want to incorporate all of it back into the develop branch so that I can have access to these features if I want to develop a different feature.