Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to get > 365 days of historical schedule data #125

Closed
wants to merge 2 commits into from

Conversation

kylematoba
Copy link

No description provided.

@gnzsnz
Copy link
Contributor

gnzsnz commented Feb 28, 2025

@kylematoba may i ask you to elaborate the motivation behind your PR.

this will break existing code.

@pavel-slama
Copy link

@kylematoba How about to:

  • keep both arguments - numDays and bar_size with default None values
  • issue DeprecationWarning when the numDays is used (not None) so that users are warned but existing code keeps working
  • add some default value when both are None
  • convert numDays into bar_size in both reqHistoricalSchedule and reqHistoricalScheduleAsync
  • reqHistoricalScheduleGeneral could be removed

Also seems like the project is using camelCase, so maybe follow that with barSize instead of bar_size.

@kylematoba kylematoba closed this by deleting the head repository Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants