feat(vectorizer): Headless ready and move into worker for demo purposes #6
Conversation
There was a problem hiding this comment.
Added my 2 cents, but I'm not deep enough into understanding the architecture yet, so can't say much to that.
I would LOVE if we could abstract away most of this plugin code into one function that takes in an image fill source set, does some work with it and returns a new set of image.
That would enable quick iteration for e.g an upscalerJS plugin
| external: ['@cesdk/cesdk-js', 'lodash', "node:path", "fs", "url"], | ||
| platform: 'browser', | ||
| external: ['@cesdk/cesdk-js'], | ||
| platform: 'node', |
There was a problem hiding this comment.
Is node correct here? In the end the plugin will be shipped in the browser. Do we need two different configs and build for either nodejs or browser maybe?
There was a problem hiding this comment.
I learned from the docs that "nodejs" is not the platform to build for, it has mechanism in place such das externalizing node modules and so forth. The platform itself has not influence on the end target.
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 |
There was a problem hiding this comment.
Can we remove this comment? It looks wrong inside a json
| // Use IntelliSense to learn about possible attributes. | |
| // Hover to view descriptions of existing attributes. | |
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 |
packages/vectorizer/src/constants.ts
Outdated
| export const PLUGIN_ID = '@imgly/plugin-vectorizer-web'; | ||
| export const CANVAS_MENU_COMPONENT_ID = `${PLUGIN_ID}.canvasMenu`; | ||
| export const CANVAS_MENU_COMPONENT_BUTTON_ID = `${CANVAS_MENU_COMPONENT_ID}.button`; | ||
| export const FEATURE_ID = `${PLUGIN_ID}.feature`; | ||
| export const I18N_ID = "plugin.vectorizer.vectorize" | ||
| export const I18N_TRANSLATIONS = { | ||
| en: { [I18N_ID]: 'Vectorize' }, | ||
| de: { [I18N_ID]: 'Vektorisieren' } | ||
| export const PLUGIN_CANVAS_MENU_COMPONENT_ID = `${PLUGIN_ID}.canvasMenu`; | ||
| export const PLUGIN_CANVAS_MENU_COMPONENT_BUTTON_ID = `${PLUGIN_CANVAS_MENU_COMPONENT_ID}.button`; | ||
| export const PLUGIN_FEATURE_ID = `${PLUGIN_ID}`; | ||
| export const PLUGIN_ACTION_VECTORIZE_LABEL = `plugin.${PLUGIN_ID}.vectorize` | ||
| export const PLUGIN_I18N_TRANSLATIONS = { | ||
| en: { [PLUGIN_ACTION_VECTORIZE_LABEL]: 'Vectorize' }, | ||
| de: { [PLUGIN_ACTION_VECTORIZE_LABEL]: 'Vektorisieren' } | ||
| } | ||
| export const ICON = '@imgly/icons/Vectorize' No newline at end of file | ||
| export const PLUGIN_ICON = '@imgly/icons/Vectorize' |
There was a problem hiding this comment.
I guess we can soon move all this data into something like a plugin manifest json
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tried the current structure.
I like the general concept, therefore I started evaluating some edge-cases and refactored the code to see fit to this edge cases and discover potential blockers