Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/server side pagination #26

Merged
merged 3 commits into from
Jan 21, 2015

Conversation

cmbankester
Copy link
Contributor

  • Added a test suite (Mocha+Karma+Chai+Sinon)

  • Added server side pagination support

    • Construction of server-side pagination differs slightly from the initial proposal:
    new DataTable({
      serverSidePagination: {
        enabled: true,
        path: '/foo/bar',
        loader: function(result){...}
      }
    });

@cmckni3
Copy link
Collaborator

cmckni3 commented Jan 21, 2015

Works pretty well. Does loading ever get set to true?

@cmbankester
Copy link
Contributor Author

Hm, no, I completely ignored loading. When should it be set to true/false? I assume just when the client is waiting on the server?

@cmckni3
Copy link
Collaborator

cmckni3 commented Jan 21, 2015

Yeah when waiting on the server. I saw it is set to false when it is finished but never set to true.

@cmbankester
Copy link
Contributor Author

Haha, mk, I'll get that in there. There are also a lot of things we can refactor in there now (a lot of public methods that don't need to be public, etc.), but I think we should do the refactoring on a 1.0.0 tag (removing public methods => not backward compatible).

@cmckni3
Copy link
Collaborator

cmckni3 commented Jan 21, 2015

Cool. That makes sense.

cmbankester added a commit that referenced this pull request Jan 21, 2015
Server-side pagination feature & test suite
@cmbankester cmbankester merged commit eb47f23 into releases/0.6.0 Jan 21, 2015
@cmbankester
Copy link
Contributor Author

Fixes #17, #24

@cmbankester cmbankester deleted the feature/server-side-pagination branch January 22, 2015 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants