Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added passing filter in GET request for server side pagination #29

Merged
merged 1 commit into from
Jan 22, 2015
Merged

Added passing filter in GET request for server side pagination #29

merged 1 commit into from
Jan 22, 2015

Conversation

cmbankester
Copy link
Contributor

Server side pagination was not passing the filter to the server.

  • Added filter passing (w/ tests)
  • Added URL-encoding of query paramaters passed to the server
  • Added PhantomJS to browsers used in test suite
  • Refactored test suite slightly

@cmckni3
Copy link
Collaborator

cmckni3 commented Jan 22, 2015

👍

cmbankester added a commit that referenced this pull request Jan 22, 2015
@cmbankester
Merge pull request #29 from immense/hotfix/server-side-filter
480a666 
Added passing filter in GET request for server side pagination
@cmbankester cmbankester merged commit 480a666 into releases/0.6.1 Jan 22, 2015
@cmbankester cmbankester deleted the hotfix/server-side-filter branch January 22, 2015 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmbankester @cmckni3