Issue fix pack #9
Conversation
Data tables - ported all computed to pureComputed and inlined attribute map computed to increase efficiency in code paths that don't require it. demo.thml - added perPage dropdown and modified search box to filter after each keypress.
| @@ -0,0 +1 @@ | |||
| {"version":3,"file":"knockout-datatable.min.js","sources":["knockout-datatable.js"],"names":["__indexOf","indexOf","item","i","l","this","length","DataTable","rows","options","sortField","Error","recordWord","recordWordPlural","sortDir","perPage","filterFn","unsortedClass","descSortClass","ascSortClass","ko","observable","currentPage","filter","loading","filtering","subscribe","_this","observableArray","rowAttributeMap","pureComputed","attrMap","key","row","hasOwnProperty","toLowerCase","filteredRows","sort","a","b","aVal","bVal","utils","unwrapObservable","pagedRows","pageIndex","slice","pages","Math","ceil","leftPagerClass","rightPagerClass","total","from","to","recordsText","showNoData","showLoading","sortClass","column","primitiveCompare","computed","item1","item2","toString","prototype","toggleSort","field","prevPage","page","nextPage","gotoPage","pageClass","defaultMatch","val","_results","push","some","isObservable","filterVar","specials","_ref","split","forEach","word","words","join","conditionals","rowAttr","call","match"],"mappings":"CAAA,WACE,GAAIA,MAAeC,SAAW,SAASC,GAAQ,IAAK,GAAIC,GAAI,EAAGC,EAAIC,KAAKC,OAAYF,EAAJD,EAAOA,IAAO,GAAIA,IAAKE,OAAQA,KAAKF,KAAOD,EAAM,MAAOC,EAAK,OAAO,GAEpJE,MAAKE,UAAY,WAmBf,QAASA,GAAUC,EAAMC,GACvB,GAAyB,MAArBA,EAAQC,UACV,KAAM,IAAIC,OAAM,8BAElBN,MAAKI,SACHG,WAAYH,EAAQG,YAAc,SAClCC,iBAAkBJ,EAAQI,iBAC1BC,QAASL,EAAQK,SAAW,MAC5BJ,UAAWD,EAAQC,UACnBK,QAASN,EAAQM,SAAW,GAC5BC,SAAUP,EAAQO,UAAY,OAC9BC,cAAeR,EAAQQ,eAAiB,GACxCC,cAAeT,EAAQS,eAAiB,GACxCC,aAAcV,EAAQU,cAAgB,IAExCd,KAAKS,QAAUM,GAAGC,WAAWhB,KAAKI,QAAQK,SAC1CT,KAAKK,UAAYU,GAAGC,WAAWhB,KAAKI,QAAQC,WAC5CL,KAAKU,QAAUK,GAAGC,WAAWhB,KAAKI,QAAQM,SAC1CV,KAAKiB,YAAcF,GAAGC,WAAW,GACjChB,KAAKkB,OAASH,GAAGC,WAAW,IAC5BhB,KAAKmB,QAAUJ,GAAGC,YAAW,GAC7BhB,KAAKoB,UAAYL,GAAGC,YAAW,GAC/BhB,KAAKkB,OAAOG,UAAU,SAAUC,GAC9B,MAAO,YACL,MAAOA,GAAML,YAAY,KAE1BjB,OACHA,KAAKU,QAAQW,UAAU,SAAUC,GAC/B,MAAO,YACL,MAAOA,GAAML,YAAY,KAE1BjB,OACHA,KAAKG,KAAOY,GAAGQ,gBAAgBpB,GAC/BH,KAAKwB,gBAAkBC,EAAa,SAAUH,GAC5C,MAAO,YACL,GAAII,GAASC,EAAKC,CAGlB,IAFAzB,EAAOmB,EAAMnB,OACbuB,KACIvB,EAAKF,OAAS,EAAG,CACnB2B,EAAMzB,EAAK,EACX,KAAKwB,IAAOC,GACNA,EAAIC,eAAeF,KACrBD,EAAQC,EAAIG,eAAiBH,GAInC,MAAOD,KAER1B,OACHA,KAAK+B,aAAeN,EAAa,SAAUH,GACzC,MAAO,YACL,GAAIJ,GAAQP,CAyCZ,OAxCAW,GAAMF,WAAU,GAChBF,EAASI,EAAMJ,SACff,EAAOmB,EAAMnB,OACE,KAAXe,IACFP,EAAWW,EAAMX,SAASO,GAC1Bf,EAAOA,EAAKe,OAAOP,IAErBR,EAAK6B,KAAK,SAASC,EAAGC,GACpB,GAAIC,GAAMC,CASV,OARAD,GAAOpB,GAAGsB,MAAMC,iBAAiBL,EAAEX,EAAMjB,cACzC+B,EAAOrB,GAAGsB,MAAMC,iBAAiBJ,EAAEZ,EAAMjB,cACrB,gBAAT8B,KACTA,EAAOA,EAAKL,eAEM,gBAATM,KACTA,EAAOA,EAAKN,eAEU,QAApBR,EAAMb,UACG2B,EAAPD,GAAwB,KAATA,GAAwB,MAARA,EAC1B,GAEHA,EAAOC,GAAiB,KAATA,GAAwB,MAARA,EAC1B,EAEA,EAIAA,EAAPD,GAAwB,KAATA,GAAwB,MAARA,EAC1B,EAEHA,EAAOC,GAAiB,KAATA,GAAwB,MAARA,EAC1B,GAEA,IAKfd,EAAMF,WAAU,GACTjB,IAERH,OACHA,KAAKuC,UAAYd,EAAa,SAAUH,GACtC,MAAO,YACL,GAAIkB,GAAW9B,CAGf,OAFA8B,GAAYlB,EAAML,cAAgB,EAClCP,EAAUY,EAAMZ,UACTY,EAAMS,eAAeU,MAAMD,EAAY9B,GAAU8B,EAAY,GAAK9B,KAE1EV,OACHA,KAAK0C,MAAQjB,EAAa,SAAUH,GAClC,MAAO,YACL,MAAOqB,MAAKC,KAAKtB,EAAMS,eAAe9B,OAASqB,EAAMZ,aAEtDV,OACHA,KAAK6C,eAAiBpB,EAAa,SAAUH,GAC3C,MAAO,YACL,MAA4B,KAAxBA,EAAML,cACD,WADT,SAIDjB,OACHA,KAAK8C,gBAAkBrB,EAAa,SAAUH,GAC5C,MAAO,YACL,MAAIA,GAAML,gBAAkBK,EAAMoB,QACzB,WADT,SAID1C,OACHA,KAAK+C,MAAQtB,EAAa,SAAUH,GAClC,MAAO,YACL,MAAOA,GAAMS,eAAe9B,SAE7BD,OACHA,KAAKgD,KAAOvB,EAAa,SAAUH,GACjC,MAAO,YACL,OAAQA,EAAML,cAAgB,GAAKK,EAAMZ,UAAY,IAEtDV,OACHA,KAAKiD,GAAKxB,EAAa,SAAUH,GAC/B,MAAO,YACL,GAAI2B,EAEJ,OADAA,GAAK3B,EAAML,cAAgBK,EAAMZ,UAC7BuC,EAAK3B,EAAMyB,QACNzB,EAAMyB,QAENE,IAGVjD,OACHA,KAAKkD,YAAczB,EAAa,SAAUH,GACxC,MAAO,YACL,GAAI0B,GAAMN,EAAOnC,EAAYC,EAAkByC,EAAIF,CAOnD,OANAL,GAAQpB,EAAMoB,QACdK,EAAQzB,EAAMyB,QACdC,EAAO1B,EAAM0B,OACbC,EAAK3B,EAAM2B,KACX1C,EAAae,EAAMlB,QAAQG,WAC3BC,EAAmBc,EAAMlB,QAAQI,kBAAoBD,EAAa,IAC9DmC,EAAQ,EACH,GAAKM,EAAO,OAASC,EAAK,OAASF,EAAQ,IAAMvC,EAEjD,GAAKuC,EAAQ,KAAOA,EAAQ,GAAe,IAAVA,EAAcvC,EAAmBD,KAG5EP,OACHA,KAAKmD,WAAa1B,EAAa,SAAUH,GACvC,MAAO,YACL,MAAoC,KAA7BA,EAAMiB,YAAYtC,SAAiBqB,EAAMH,YAEjDnB,OACHA,KAAKoD,YAAc3B,EAAa,SAAUH,GACxC,MAAO,YACL,MAAOA,GAAMH,YAEdnB,OACHA,KAAKqD,UAAY,SAAU/B,GACzB,MAAO,UAASgC,GACd,MAAO7B,GAAa,WAClB,MAAIH,GAAMjB,cAAgBiD,EACjB,WAAiC,QAApBhC,EAAMb,UAAsBa,EAAMlB,QAAQU,aAAeQ,EAAMlB,QAAQS,eAEpFS,EAAMlB,QAAQQ,kBAI1BZ,MArML,GAAIuD,GAAkB9B,CAmUtB,OAjUAA,GAAeV,GAAGU,cAAgBV,GAAGyC,SAErCD,EAAmB,SAASE,EAAOC,GACjC,MAAa,OAATA,EACc,MAATD,EACW,MAATA,EACY,iBAAVA,GACFA,IAAUC,EAEVD,EAAME,WAAW7B,cAAclC,QAAQ8D,EAAMC,WAAW7B,gBAAkB,GAAK2B,IAAUC,GAG3F,GA0LXxD,EAAU0D,UAAUC,WAAa,SAASC,GACxC,MAAO,UAAUxC,GACf,MAAO,YAEL,MADAA,GAAML,YAAY,GACdK,EAAMjB,cAAgByD,EACjBxC,EAAMb,QAA4B,QAApBa,EAAMb,UAAsB,OAAS,QAE1Da,EAAMb,QAAQ,OACPa,EAAMjB,UAAUyD,MAG1B9D,OAGLE,EAAU0D,UAAUG,SAAW,WAC7B,GAAIC,EAEJ,OADAA,GAAOhE,KAAKiB,cACC,IAAT+C,EACKhE,KAAKiB,YAAY+C,EAAO,GADjC,QAKF9D,EAAU0D,UAAUK,SAAW,WAC7B,GAAID,EAEJ,OADAA,GAAOhE,KAAKiB,cACR+C,IAAShE,KAAK0C,QACT1C,KAAKiB,YAAY+C,EAAO,GADjC,QAKF9D,EAAU0D,UAAUM,SAAW,SAASF,GACtC,MAAO,UAAU1C,GACf,MAAO,YACL,MAAOA,GAAML,YAAY+C,KAE1BhE,OAGLE,EAAU0D,UAAUO,UAAY,SAASH,GACvC,MAAOvC,GAAa,SAAUH,GAC5B,MAAO,YACL,MAAIA,GAAML,gBAAkB+C,EACnB,SADT,SAIDhE,QAGLE,EAAU0D,UAAUQ,aAAe,SAASlD,EAAQU,EAAKF,GACvD,GAAIC,GAAK0C,CACT,OAAQ,YACN,GAAIC,EACJA,KACA,KAAK3C,IAAOD,GACV2C,EAAM3C,EAAQC,GACd2C,EAASC,KAAKF,EAEhB,OAAOC,MACHE,KAAK,SAASH,GAClB,MAAOd,GAAkBxC,GAAG0D,aAAa7C,EAAIyC,IAAQzC,EAAIyC,KAASzC,EAAIyC,GAAOnD,MAIjFhB,EAAU0D,UAAUjD,SAAW,SAAS+D,GACtC,GAAIN,GAAclD,EAAQyD,EAAUC,CACpC,OAA6B,OAAzB5E,KAAKI,QAAQO,SACRX,KAAKI,QAAQO,SAAS+D,IAE7BE,UAAiB1D,EAAS0D,EAAK,GAAID,EAAWC,EAAK,GACnDF,EAAUG,MAAM,KAAKC,QAAQ,SAASC,GACpC,GAAIC,EACJ,OAAID,GAAKnF,QAAQ,MAAQ,GACvBoF,EAAQD,EAAKF,MAAM,KACZF,EAASK,EAAM,IAAM,WAC1B,OAAQA,EAAM,GAAGlD,eACf,IAAK,MACL,IAAK,OACH,OAAO,CACT,KAAK,KACL,IAAK,QACH,OAAO,CACT,KAAK,QACL,IAAK,OACL,IAAK,OACL,IAAK,YACH,MAAO,OACT,SACE,MAAOkD,GAAM,GAAGlD,mBAIfZ,EAAOqD,KAAKQ,KAGvB7D,EAASA,EAAO+D,KAAK,KACrBb,EAAepE,KAAKoE,aACb,SAAU9C,GACf,MAAO,UAASM,GACd,GAAIsD,GAAcvD,EAAK0C,CAmBvB,OAlBAa,GAAe,WACb,GAAIZ,EACJA,KACA,KAAK3C,IAAOgD,GACVN,EAAMM,EAAShD,GACf2C,EAASC,KAAK,SAAUjD,GACtB,MAAO,UAASK,EAAK0C,GACnB,GAAIc,EACJ,QAAIA,EAAU7D,EAAME,kBAAkBG,EAAIG,gBACjCyB,EAAkBxC,GAAG0D,aAAa7C,EAAIuD,IAAYvD,EAAIuD,KAAavD,EAAIuD,GAAWd,IAElF,IAGVrE,MAAM2B,EAAK0C,GAEhB,OAAOC,IACNc,KAAK9D,GACA3B,EAAUyF,KAAKF,GAAc,GAAS,IAAkB,KAAXhE,EAA8B,MAAbU,EAAIyD,MAAgBzD,EAAIyD,MAAMnE,GAAUkD,EAAalD,EAAQU,EAAKN,EAAME,oBAAsB,KAErKxB,QAIAE,OAIRkF,KAAKpF"} | |||
There was a problem hiding this comment.
Is this needed for the end user? I.e., should we add this file to the bower.json's ignore section so it doesn't get installed when someone bower installs the datatable?
Covered a few other computeds, updated the demo to showcase changing perPage
|
Thanks for this! Really helped us out. Great change to the demo! |
|
Hey it was the least I could do :) |
|
Sorry for being such a noob, but where can I see the change? |
|
Hmm. Well, I'm trying to be as lean as possible with what gets installed via The changes are currently sitting in the release branch. |
|
@ohadschn I went ahead and reverted, since it can't do any harm to have them in there. I'm just not certain on their use. |
|
Source map files are super useful when you want to debug minified js files. It basically allows you to deploy minified files with all their benefits, but come debugging time you can place breakpoints and the likes in the debug (non-minified) file. It looks like even coffeescript debugging is supported, so you might want to put it back: https://developer.chrome.com/devtools/docs/javascript-debugging#source-maps. The developer can always choose what they want, it's not like there's a size issue... |
|
@ohadschn This is all sitting in master now. If you're using bower, you should be able to get the updates by specifying version 0.5.0 in your bower.json. Somewhat relatedly, do you want me to add you to the Contributors list? I'll link it to your GitHub page (or somewhere else, if you'd rather). |
|
Fantastic! I see you've made some more improvements along the way - good stuff! |
Data tables - ported all computed to pureComputed and inlined attribute map computed to increase efficiency in code paths that don't require it.
demo.thml - added perPage dropdown and modified search box to filter after each keypress.