Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing glClear call to layer samples #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

idrisshah
Copy link

@idrisshah idrisshah commented Jan 25, 2024

Quad layer samples are broken because of missing glClear on Magic Leap system. These samples miss a glClear call before every frame rendered.

** This patch is funded by Magic Leap

Copy link
Member

@cabanier cabanier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clear isn't needed. WebXR Textures are supposed to be cleared when you get them.
See https://immersive-web.github.io/layers/#xropaquetextures

I agree that this is not obvious from an implementor's point of view. It was hard to implement in a performant way

@idrisshah
Copy link
Author

Thanks for this clarification. I missed that part. In that case, there are some samples that still have glClear calls like: https://immersive-web.github.io/webxr-samples/layers-samples/proj-layer.html. Should those be cleaned up for consistency?

@cabanier
Copy link
Member

Thanks for this clarification. I missed that part. In that case, there are some samples that still have glClear calls like: https://immersive-web.github.io/webxr-samples/layers-samples/proj-layer.html. Should those be cleaned up for consistency?

yes, that would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants