fix: github discussions references #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
Dec 14, 2023
jrasm91
reviewed
Dec 14, 2023
src/events/messageEvents.ts
Outdated
| if (response.status === 200) { | ||
| const type = response.data.pull_request ? 'PR' : 'ISSUE'; | ||
| links.add(`[${type}] ${response.data.title} ([#${id}](${response.data.html_url}))`); | ||
| const type = response.data.pull_request ? 'PR' : 'ISSUE'; |
There was a problem hiding this comment.
all the try/catch stuff looks a bit messy to me. Maybe you could:
- If no matches, continue (and de-indent everything - top of the for loop)
- Move the github requests to private functions that return a string or null.
- Update the for loop to just be
const link = await this.getIssueOrPR(id) || await this.getDiscussion(id);
jrasm91
approved these changes
Dec 14, 2023
danieldietzler
force-pushed
the
fix/github-discussions-references
branch
from
86c6e18 to
88bb3ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.