Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jorwoods/cibuildwheel #204

Merged
merged 23 commits into from
Dec 3, 2023
Merged

Jorwoods/cibuildwheel #204

merged 23 commits into from
Dec 3, 2023

Conversation

jorwoods
Copy link
Collaborator

  • Add CI pipeline to build wheels for all platforms and python versions.
  • Replace deprecated distutils reference
  • Add pytest configuration to pyproject.toml

@jorwoods
Copy link
Collaborator Author

Can the wheels.yml action replace the pythonpublish and pythonpackage actions?

pantab/_compat.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@WillAyd
Copy link
Collaborator

WillAyd commented Nov 30, 2023

Can the wheels.yml action replace the pythonpublish and pythonpackage actions?

pythonpublish can be replaced by this. pythonpackage is a misnomer - that is responsible for running the test suite when pull requests happen

Would be open to renmaing pythonpackage to something more meaningful here or in another PR

@jorwoods
Copy link
Collaborator Author

jorwoods commented Dec 1, 2023

Can the wheels.yml action replace the pythonpublish and pythonpackage actions?

pythonpublish can be replaced by this. pythonpackage is a misnomer - that is responsible for running the test suite when pull requests happen

Would be open to renmaing pythonpackage to something more meaningful here or in another PR

Removed redundant workflow yaml.

@WillAyd
Copy link
Collaborator

WillAyd commented Dec 1, 2023

This looks great. All for it if we get CI green

pantab/_compat.py Outdated Show resolved Hide resolved
@WillAyd
Copy link
Collaborator

WillAyd commented Dec 1, 2023

FYI you might want to look at using pre-commit for contributions here - we have the config for it. Will catch most if not all linting errors before you can commit

@jorwoods jorwoods force-pushed the jorwoods/cibuildwheel branch from 8fb68d9 to f3067bb Compare December 1, 2023 03:44
@jorwoods
Copy link
Collaborator Author

jorwoods commented Dec 1, 2023

I did overlook the pre-commit config. Enabled that locally.

@WillAyd
Copy link
Collaborator

WillAyd commented Dec 1, 2023

Looks great. Not sure what's up with the pandas 3.12 tests

@WillAyd
Copy link
Collaborator

WillAyd commented Dec 1, 2023

Looks like the 3.12 jobs actually use python 3.8

https://github.com/innobi/pantab/actions/runs/7055453091/job/19205917274?pr=204#step:3:3

@jorwoods
Copy link
Collaborator Author

jorwoods commented Dec 1, 2023

I removed the redundant lines from the pyproject.toml. I'll take another look at it soon to see if I can figure out why it uses the wrong version for only 3.12.

@WillAyd WillAyd merged commit fe7f536 into innobi:main Dec 3, 2023
19 checks passed
@WillAyd
Copy link
Collaborator

WillAyd commented Dec 3, 2023

Fantastic work @jorwoods - thanks so much!


PANDAS_120 = LooseVersion(pd.__version__) >= LooseVersion("1.2.0")
PANDAS_130 = LooseVersion(pd.__version__) >= LooseVersion("1.3.0")
PANDAS_120 = parse(pd.__version__) >= parse("1.2.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted to make another contribution, we can also completely rip out the pandas 1.2 compatability code from the code base. Any time this is referenced and I think the legacy functions in the C extensions are due for cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants