-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jorwoods/cibuildwheel #204
Conversation
Can the wheels.yml action replace the pythonpublish and pythonpackage actions? |
pythonpublish can be replaced by this. pythonpackage is a misnomer - that is responsible for running the test suite when pull requests happen Would be open to renmaing pythonpackage to something more meaningful here or in another PR |
Removed redundant workflow yaml. |
This looks great. All for it if we get CI green |
FYI you might want to look at using pre-commit for contributions here - we have the config for it. Will catch most if not all linting errors before you can commit |
8fb68d9
to
f3067bb
Compare
I did overlook the pre-commit config. Enabled that locally. |
Looks great. Not sure what's up with the pandas 3.12 tests |
Looks like the 3.12 jobs actually use python 3.8 https://github.com/innobi/pantab/actions/runs/7055453091/job/19205917274?pr=204#step:3:3 |
I removed the redundant lines from the pyproject.toml. I'll take another look at it soon to see if I can figure out why it uses the wrong version for only 3.12. |
Fantastic work @jorwoods - thanks so much! |
|
||
PANDAS_120 = LooseVersion(pd.__version__) >= LooseVersion("1.2.0") | ||
PANDAS_130 = LooseVersion(pd.__version__) >= LooseVersion("1.3.0") | ||
PANDAS_120 = parse(pd.__version__) >= parse("1.2.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted to make another contribution, we can also completely rip out the pandas 1.2 compatability code from the code base. Any time this is referenced and I think the legacy functions in the C extensions are due for cleanup
distutils
reference