Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: bump Celery version #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmartinm
Copy link
Contributor

@jmartinm jmartinm commented Nov 9, 2017

No description provided.

@ghost ghost assigned jmartinm Nov 9, 2017
@ghost ghost added the Status: WIP label Nov 9, 2017
@jacquerie
Copy link
Contributor

You'll want to make this generate a major version, otherwise you're going to break the build!

@jacquerie
Copy link
Contributor

jacquerie commented Nov 9, 2017

As for this build not passing, see: inveniosoftware/troubleshooting#8.

@jmartinm
Copy link
Contributor Author

jmartinm commented Nov 9, 2017

As for this build not passing, see: inveniosoftware/troubleshooting#8.

Let's see if it works now, although even applying the changes in inveniosoftware/invenio-indexer@e044428 I am getting the error locally.

You'll want to make this generate a major version, otherwise you're going to break the build!

@david-caro is there a way to mark it in the commit message?

@david-caro
Copy link
Contributor

david-caro commented Nov 10, 2017

Yes, you can even do it from the ui on github when you hit the merge button, you can add to it (at the end):

My message

Sem-Ver: breaking change

That will tag it as major change.

@jmartinm
Copy link
Contributor Author

Depends on celery/vine#18

@jmartinm
Copy link
Contributor Author

jmartinm commented Dec 4, 2017

The issue with Celery was fixed in celery/celery#4399. Once a new release of Celery 4 is done, this can unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants