hal: use inspire-utils to parse names #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacquerie
changed the title
8 tasks
|
The record that doesn't pass validation in https://travis-ci.org/inspirehep/inspire-next/jobs/307298427 is because of inspirehep/inspire-schemas#280. |
|
And all the failing tests in https://travis-ci.org/inspirehep/inspire-next/jobs/307298424 might be because of the same reason, as |
jacquerie
commented
Nov 26, 2017
| @@ -72,7 +75,8 @@ def test_set_schema_builds_a_full_url_for_the_schema(): | |||
|
|
|||
| data = {'$schema': 'hep.json'} | |||
| extra_data = {} | |||
| assert validate(data['$schema'], subschema) is None | |||
| with pytest.raises(ValidationError): | |||
| validate(data['$schema'], subschema) is None | |||
There was a problem hiding this comment.
This is notable: inspire-dojson puts something invalid there, and set_schema makes it valid. This is the only exception to the usual task invariant (valid in, valid out).
This was referenced Nov 26, 2017
As currently the Authors schema can't correctly express a Twitter profile link we remove this field so that it won't cause a validation error during migration of the demo records. This commit should be reverted when inspirehep/inspire-schemas#182 is merged. Signed-off-by: Jacopo Notarstefano <[email protected]>
Signed-off-by: Jacopo Notarstefano <[email protected]>
Signed-off-by: Jacopo Notarstefano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Addresses #2273, supersedes #2990.
Checklist:
RFCand look for it).