Skip to content

Commit

Permalink
fix: removed protobuf from requirements list
Browse files Browse the repository at this point in the history
Signed-off-by: Cagri Yonca <[email protected]>
  • Loading branch information
CagriYonca committed Nov 11, 2024
1 parent 827557c commit 721d497
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ classifiers = [
dependencies = [
"autowrapt>=1.0",
"fysom>=2.1.2",
"protobuf<5.0.0",
"requests>=2.6.0",
"six>=1.12.0",
"urllib3>=1.26.5",
Expand Down
2 changes: 1 addition & 1 deletion tests/apps/grpc_server/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
To regenerate from the proto file:

```bash
pip install grpcio grpcio-tools
pip install grpcio grpcio-tools protobuf
python -m grpc_tools.protoc --proto_path=. --python_out=. --grpc_python_out=. ./stan.proto
```

Expand Down
7 changes: 0 additions & 7 deletions tests/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ mysqlclient>=2.0.3
PyMySQL[rsa]>=1.0.2
psycopg2-binary>=2.8.6
pika>=1.2.0
# protobuf is pulled in and also `basictracer`, a core instana dependency
# and also by google-cloud-storage
# but also directly needed by tests/apps/grpc_server/stan_pb2.py
# On 4.0.0 we currently get:
# AttributeError: module 'google._upb._message' has no attribute 'Message'
# TODO: Remove this when support for 4.0.0 is done
protobuf<4.0.0
pymongo>=3.11.4
pyramid>=2.0.1
pytest>=6.2.4
Expand Down

0 comments on commit 721d497

Please sign in to comment.