Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve focus managmenet #63

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

eschiebel
Copy link
Member

This makes three changes to help improve focus management

  1. if the editor associated with an a11y checker is removed, close the checker
  2. when the checker is closed, focus the associated editor
  3. add the data-mce-checker attribute to the checker's Tray component.
    Consuming applications may use this to detect that even though focus
    may have left the editor, it is still within a compnent that can be
    considered a paart of the editor's ecosystem.

This makes three changes to help improve focus management
1. if the editor associated with an a11y checker is removed, close the checker
2. when the checker is closed, focus the associated editor
3. add the data-mce-checker attribute to the checker's Tray component.
   Consuming applications may use this to detect that even though focus
   may have left the editor, it is still within a compnent that can be
   considered a paart of the editor's ecosystem.
@eschiebel eschiebel requested a review from a team as a code owner June 27, 2019 19:18
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
All committers have signed the CLA.

This makes three changes to help improve focus management
1. if the editor associated with an a11y checker is removed, close the checker
2. when the checker is closed, focus the associated editor
3. add the data-mce-checker attribute to the checker's Tray component.
   Consuming applications may use this to detect that even though focus
   may have left the editor, it is still within a compnent that can be
   considered a paart of the editor's ecosystem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants