-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse architecture
from PyTorch
instead of hard coding
#2995
Conversation
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
aa8c13c
to
a853d16
Compare
Signed-off-by: Whitney Tsang <[email protected]>
4e1e895
to
d378a2b
Compare
Signed-off-by: Whitney Tsang <[email protected]>
37b6217
to
47a3216
Compare
Signed-off-by: Whitney Tsang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Looks like this change makes CI slower (~2h vs ~1.5h). |
Signed-off-by: Whitney Tsang <[email protected]>
…ged" This reverts commit 5e6d2c9.
Signed-off-by: Whitney Tsang <[email protected]>
Maybe we can cache the hardware capability to reduce the number call of |
New CI time is 1h 36m 48s, let's see how much more caching can reduce. |
Signed-off-by: Whitney Tsang <[email protected]>
With caching, further reduced to 1h 25m 26s. |
With pytorch/pytorch#138186,
architecture
is added to XPU device property.Instead of hard coding
pvc
when invokingocloc
, this PR changed to dynamically passing the device architecture parsed.