-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
42compress #142
Open
desmonddak
wants to merge
18
commits into
intel:main
Choose a base branch
from
desmonddak:42compress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
42compress #142
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5668789
4:2 compressors working
desmonddak 73aac77
BitCompressors use terms instead of bitvector
desmonddak 0658a17
fix unused variable
desmonddak c98c7dd
add use42Compressors to configurator and resolve trace error
desmonddak ffe15af
typos
desmonddak d562567
4:2 compressors validate
ganewto 3dd5a04
Merge branch 'main' into 42compress
ganewto d23fd0c
some code cleanup (e.g., commented out already)
ganewto 219c84e
Merge branch 'main' into 42compress
desmonddak 7f85a6e
make LogicValue extensions private to test file
desmonddak 1cfbeef
Merge branch '42compress' of https://github.com/desmonddak/rohd-hcl i…
desmonddak 1d52ff5
merge fixes
desmonddak 94c2b9f
Merge branch '42compress' of https://github.com/desmonddak/rohd-hcl i…
desmonddak 252be00
cleanup logicvalue extension
desmonddak a34bc10
Merge branch 'main' into 42compress
desmonddak 0bf12e0
fixed merge issues from web edits
desmonddak eaa6cdc
pattern for generating cin for compressor4 worked, but would not exte…
desmonddak 21081a8
remove unused import dart:io used for checking Verilog output
desmonddak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it may be useful to expose a
@protected
API for setting these delays rather than private, so that if someone has a technology-specific delay they want to set, they could just extend one of the compressors and change the delay numbers? this also leads to another question: should there be an argument to generate compressors inColumnCompressor
(even the smaller ones) rather than just a flag on whether to use 4:2 or not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bare minimum is to use 2:2 and 3:2 compressors (half and full-adders). But you have a point -- people have invented even wider compressors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to include changes to support arbitrary delays and user-defined compressors in this PR? one consideration is this flag to "use 4:2 compressors" is an API that wouldn't really make sense if we later replace it with a list of compressor types that can be used, for example