Ignore hidden projects #272
Conversation
|
@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
|
|
| @@ -424,6 +424,11 @@ Iterable<String> _findRoots(String path) sync* { | |||
| final directory = Directory(path); | |||
|
|
|||
| yield* directory.listSync(recursive: true).whereType<File>().where((file) { | |||
| final relativePathSegments = split(relative(file.path)); | |||
There was a problem hiding this comment.
I think the correct fix is to remove this and the isChildFromCache logic and always return packageConfig.existsSync
|
Do we still need a test for this? Is there an existing test I can modify? |
|
We always need tests :) You can modify the one that was added in the previous attempt at fixing this issue: 773b7ef |
|
@rrousselGit I updated the test and double checked that it fails without the fix |
|
@rrousselGit can we get this merged? |
|
I'll fix the CI tomorrow. We'll then see if this PR doesn't cause any regression |
Fixes #271