feat: Add enforce lockfile bootstrap command config #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLockfile property
|
|
Ayman-Barghout
changed the title
Ayman-Barghout
changed the title
|
@Ayman-Barghout the analyzer warnings are already fixed in #602, no harm in fixing them in here too to show that it is green though, as long as the other one is merged first. :) |
Oh, my bad, didn't notice :) sure thing, I am gonna wait till #602 merge then 🙌 |
spydon
approved these changes
Dec 4, 2023
|
Could we add this as a flag to bootstrap too, |
|
@Ayman-Barghout did you see Salakar's comment? |
Sadly not, just noticed it when you pinged 🙂 will work on it ASAP |
|
@Ayman-Barghout you can have a look at #604 to see how to do it :) |
spydon
reviewed
Dec 18, 2023
spydon
approved these changes
Dec 18, 2023
Co-authored-by: Lukas Klingsbo <[email protected]>
Co-authored-by: Lukas Klingsbo <[email protected]>
Co-authored-by: Lukas Klingsbo <[email protected]>
Co-authored-by: Lukas Klingsbo <[email protected]>
Co-authored-by: Lukas Klingsbo <[email protected]>
Co-authored-by: Lukas Klingsbo <[email protected]>
Co-authored-by: Lukas Klingsbo <[email protected]>
spydon
approved these changes
Dec 19, 2023
Salakar
pushed a commit
that referenced
this pull request
Dec 29, 2023
* Enforce lockfile for CI environments * Add enforce lockfile to bootstrap command config * Enforce lockfile based on the bootstrap command workspace config * Update overview.mdx with enforce lockfile option * Update the `docstring` for `enforceLockfile` to include it is default for CI * Update workspace config and bootstrap tests to include the new enforceLockfile property * Stop enforcing lock file on CI by default * Remove unnecessary parenthesis as linter is complaining * Update enforcing lock files to be inclusive of Dart as well as Flutter Co-authored-by: Lukas Klingsbo <[email protected]> * Add `--enforce-lockfile` as a bootstrap flag * Fix duplicate calling of enforce lockfile flag * Consolidate bootstrap flags documentation * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx formatting Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/configuration/overview.mdx for better clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/configuration/overview.mdx for better clarity Co-authored-by: Lukas Klingsbo <[email protected]> --------- Co-authored-by: Lukas Klingsbo <[email protected]>
spydon
added a commit
that referenced
this pull request
Jan 11, 2024
* Enforce lockfile for CI environments * Add enforce lockfile to bootstrap command config * Enforce lockfile based on the bootstrap command workspace config * Update overview.mdx with enforce lockfile option * Update the `docstring` for `enforceLockfile` to include it is default for CI * Update workspace config and bootstrap tests to include the new enforceLockfile property * Stop enforcing lock file on CI by default * Remove unnecessary parenthesis as linter is complaining * Update enforcing lock files to be inclusive of Dart as well as Flutter Co-authored-by: Lukas Klingsbo <[email protected]> * Add `--enforce-lockfile` as a bootstrap flag * Fix duplicate calling of enforce lockfile flag * Consolidate bootstrap flags documentation * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx for clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/commands/bootstrap.mdx formatting Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/configuration/overview.mdx for better clarity Co-authored-by: Lukas Klingsbo <[email protected]> * Update docs/configuration/overview.mdx for better clarity Co-authored-by: Lukas Klingsbo <[email protected]> --------- Co-authored-by: Lukas Klingsbo <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is to ensure which versions are being used, as minor changes sadly can have breaking changes to your codebase (conflicting names for example), so this option is to make sure all machines/environments are running the same versions.
This resolves #575.
Edit: Enforcing it on CI isn't a good idea as some monorepos don't check in lock files for packages if they are published, so it should always be optional.
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore