feat(ui): optimized boards queries #6603
Draft
+384
−323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
api
python
hipsterusername
approved these changes
Jul 12, 2024
psychedelicious
force-pushed
the
psyche/board-counts
branch
from
6b9f109
to
fcc3f7f
Compare
3 tasks
psychedelicious
commented
Jul 12, 2024
maryhipp
reviewed
Jul 14, 2024
…cover image This _substantially_ reduces the number of queries required to list all boards. A single query now gets one, all, or a page of boards, including counts and cover image name. - Add helpers to build the queries, which share a common base with some joins. - Update `BoardRecord` to include the counts. - Update `BoardDTO`, which is now identical to `BoardRecord`. I opted to not remove `BoardDTO` because it is used in many places. - Update boards high-level service and board records services accordingly.
chore(ui): typegen
psychedelicious
force-pushed
the
psyche/board-counts
branch
from
dae775f
to
9d3a72f
Compare
|
|
Marked draft to prevent premature merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize board related queries, reducing the number of SQL queries and network requests needed to list boards.
Fixes incorrect board image counts.
Related Issues / Discussions
n/a
QA Instructions
The UI should list boards and their counts accurately, and moving images around in a board should work as it did before.
Merge Plan
Checklist