Generalize preview event #6777
Closed
Generalize preview event #6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StAlKeR7779
requested review from
lstein,
blessedcoolant,
brandonrising,
RyanJDick,
hipsterusername and
psychedelicious
as code owners
github-actions
bot
added
python
|
I have done something similar in #6715 I paused on working on it bc focusing on canvas |
Yeah, but here idea for now - unhardcode backend, without logical/data changes, so that my code still use old event, just it's construction logic moved to be able provide different latents->image part. |
If schedulers will be rewriten in future there high chance that it field will be unused/removed.
RyanJDick
approved these changes
Aug 30, 2024
| @@ -265,7 +276,7 @@ def latents_from_embeddings( | |||
| seed: int, | |||
| timesteps: torch.Tensor, | |||
| init_timestep: torch.Tensor, | |||
| callback: Callable[[PipelineIntermediateState], None], | |||
| callback: Callable[[...], None], | |||
There was a problem hiding this comment.
Invalid type annotation. The correct syntax is:
Suggested change
| callback: Callable[[...], None], | |
| callback: Callable[..., None], |
| cls, | ||
| sample: torch.Tensor, | ||
| base_model: BaseModelType, | ||
| ) -> Tuple[Image, int]: |
There was a problem hiding this comment.
Type hint is wrong
Suggested change
| ) -> Tuple[Image, int]: | |
| ) -> Tuple[Image.Image, int]: |
There was a problem hiding this comment.
See #6715 for a more generalized approach that would supersede the public API changes in this PR.
3 tasks
|
superseded by #6908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes preview event the way, that it accepts image instead of latents.
This allow to use custom latents preview logic, for example - flux or use taesd for sd preview.
Related Issues / Discussions
#6739
QA Instructions
-
Merge Plan
-
Checklist
@brandonrising @RyanJDick