Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(components/properties.md): update erroneous closing tags on components #1472

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

JacquesRamsdenGit
Copy link
Contributor

Update components properties.md file:

Some of the components had different closing tags to the opening tags specified by the component creation.

Linked to issue #1471

…nents.

Some of the components had different closing tags to the opening tags specified by the component creation.
@JacquesRamsdenGit JacquesRamsdenGit requested a review from a team as a code owner August 15, 2024 10:56
@JacquesRamsdenGit JacquesRamsdenGit requested review from christian-bromann and tanner-reits and removed request for a team August 15, 2024 10:56
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:54am

@tanner-reits
Copy link
Member

Hi @JacquesRamsdenGit! Thanks for finding and fixing this! Looks like this is a problem with (potentially) all prior versions of the docs as well. Would you mind updating them as well, or I'm happy to do a clean sweep to fix them all in a separate PR. Just let me know!

@JacquesRamsdenGit
Copy link
Contributor Author

JacquesRamsdenGit commented Aug 15, 2024

Sure @tanner-reits, I will clone the entire repo and have a look. Might only get to it in a day or so

@JacquesRamsdenGit
Copy link
Contributor Author

Hi @tanner-reits, PR has been updated. Fixed all the files I could find.

@tanner-reits
Copy link
Member

@JacquesRamsdenGit Awesome! Looks good, I'll get this merged. Thanks for your help!

@tanner-reits tanner-reits merged commit 3eaa988 into ionic-team:main Aug 16, 2024
5 checks passed
@JacquesRamsdenGit
Copy link
Contributor Author

@tanner-reits No problem. Thanks for the great product!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants