Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add countdown logic for mana generation in implicit account creation #8222

Merged
merged 36 commits into from
Mar 25, 2024
Merged

feat: add countdown logic for mana generation in implicit account creation #8222

merged 36 commits into from
Mar 25, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Mar 19, 2024

Closes #8055

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

cpl121 and others added 19 commits March 6, 2024 15:16
@cpl121
feat: implement logic to allow tx or not based on mana cost for the X…
ff44d76 
… slots
@marc2332
fixes and clean up
46aa693
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
357cedd
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
0c25980
@marc2332
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
24899df
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
37dfe97
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
f327b18
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
9f959e7
@cpl121
Merge branches 'feat/add-buffer-to-show-mana-cost' and 'develop-iota2…
5b3ce04 
….0' of github.com:iotaledger/firefly into feat/add-buffer-to-show-mana-cost
@cpl121
feat: add mana cost to mint, burn, send and implicitTransition
719d742
@cpl121
feat: improvements in mana box component
ba4c3dd
@cpl121
feat: add mana cost to claim activity
c106747
@cpl121
feat: add mana cost to create delegation
331bddd
@cpl121
feat: add mana cost to claim shimmer
e46319b
@cpl121
Merge branch 'develop-iota2.0' into feat/add-buffer-to-show-mana-cost
39bd5f9
@cpl121
Merge branch 'feat/add-buffer-to-show-mana-cost' into feat/add-mana-c…
efb799c 
…ost-everywhere
@cpl121
fixes
f8e1472
@cpl121
Merge branches 'feat/add-mana-cost-everywhere' and 'feat/add-buffer-t…
b40de0c 
…o-show-mana-cost' of github.com:iotaledger/firefly into feat/add-mana-cost-everywhere
@cpl121
feat: add countdown logic for mana generation in implicit account cre…
5dfbdca 
…ation WIP
@cpl121 cpl121 linked an issue Mar 19, 2024 that may be closed by this pull request
[Task]: Add countdown logic for mana generation in implicit account creation #8055
Closed
@cpl121
Merge branches 'feat/add-mana-cost-everywhere' and 'develop-iota2.0' …
9a428ba 
…of github.com:iotaledger/firefly into feat/add-mana-cost-everywhere
@cpl121
fix: add conditional chaining
d837904
@cpl121
Merge branches 'feat/add-countdown-logic-for-mana-generation' and 'fe…
e252c6c 
…at/add-mana-cost-everywhere' of github.com:iotaledger/firefly into feat/add-countdown-logic-for-mana-generation
@cpl121
fix: improvements
a0d5fb5
@cpl121
Merge branches 'feat/add-mana-cost-everywhere' and 'develop-iota2.0' …
1e7af29 
…of github.com:iotaledger/firefly into feat/add-mana-cost-everywhere
@cpl121
Merge branches 'feat/add-countdown-logic-for-mana-generation' and 'fe…
cc5effe 
…at/add-mana-cost-everywhere' of github.com:iotaledger/firefly into feat/add-countdown-logic-for-mana-generation
@cpl121
fix: improvements
1b99c7b
@cpl121 cpl121 marked this pull request as ready for review March 21, 2024 08:41
@evavirseda evavirseda self-requested a review March 21, 2024 09:18
evavirseda
evavirseda reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm having this error while i'm on this view... but the transition is proceeding correctly 🤯 it's weird..
image

Base automatically changed from feat/add-mana-cost-everywhere to develop-iota2.0 March 21, 2024 16:51
@cpl121
Merge branches 'feat/add-countdown-logic-for-mana-generation' and 'de…
706700d 
…velop-iota2.0' of github.com:iotaledger/firefly into feat/add-countdown-logic-for-mana-generation
@cpl121
Copy link
Member Author

cpl121 commented Mar 21, 2024

i'm having this error while i'm on this view... but the transition is proceeding correctly 🤯 it's weird.. image

we can look later
#8246

@cpl121 cpl121 requested a review from evavirseda March 21, 2024 16:58
evavirseda
evavirseda approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@begonaalvarezd begonaalvarezd merged commit dbb3dd5 into develop-iota2.0 Mar 25, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/add-countdown-logic-for-mana-generation branch March 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add countdown logic for mana generation in implicit account creation
4 participants
@cpl121 @begonaalvarezd @evavirseda @marc2332