Skip to content

Commit

Permalink
miDbe window priv priv is pre-allocated, don't use dixSetPrivate (bug…
Browse files Browse the repository at this point in the history
… 28639)

miDbeInit pre-allocates space in each DBE window private private for a
MiDbeWindowPrivPrivRec. miDbeAllocBackBufferName used the
pre-allocated space correctly (simply fetching it instead of
allocating a new piece of memory). However, it then called
dixSetPrivate anyways, which isn't necessary, and (in the new
dixPrivate world) causes an assert failure.

Signed-off-by: Keith Packard <[email protected]>
Tested-by: Magnus Kessler <[email protected]>
Reviewed-by: Magnus Kessler <[email protected]>
  • Loading branch information
keith-packard committed Jul 2, 2010
1 parent a94cb40 commit 9f0b193
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions dbe/midbe.c
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,6 @@ miDbeAllocBackBufferName(WindowPtr pWin, XID bufId, int swapAction)
return (rc == Success) ? BadAlloc : rc;
}


/* Attach the priv priv to the priv. */
dixSetPrivate(&pDbeWindowPriv->devPrivates, miDbeWindowPrivPrivKey,
pDbeWindowPrivPriv);


/* Clear the back buffer. */
pGC = GetScratchGC(pWin->drawable.depth, pWin->drawable.pScreen);
if ((*pDbeScreenPriv->SetupBackgroundPainter)(pWin, pGC))
Expand Down

0 comments on commit 9f0b193

Please sign in to comment.