Checking if there is any missing value to prevent the algorithm from running #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base class before running solve method for subclasses
|
Thank you for your contribution. We aren't really updating the package. Since this isn't a bug, I am sorry to say we won't be prioritizing this PR. I'll leave it open - if we have to merge a bugfix some day, I'll merge this too so the pip update has both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this implementation. It is really helpful. I'd like to contribute to prevent the solver from unnecessary running for complete data. I found a way to check if the data has any Nan values in the solver method of the base class.
Thanks for the consideration.