-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt MxRegion.h
#1393
base: master
Are you sure you want to change the base?
Adapt MxRegion.h
#1393
Conversation
// TEMPLATE: BETA10 0x1014b640 | ||
// MxPtrListCursor<MxSpan>::~MxPtrListCursor<MxSpan> | ||
|
||
// SYNTHETIC: LEGO1 0x100c3ca0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a TEMPLATE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it's both synthetic and template. I'm not sure if we decided what takes preference in cases like these, I think it's relatively inconsistent in the code base so far
} | ||
|
||
// FUNCTION: LEGO1 0x100c3690 | ||
MxRegion::~MxRegion() | ||
{ | ||
if (m_list) { | ||
delete m_list; | ||
if (m_spanList) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove the if
here for a better beta match.
MxRegionLeftRight* leftRight; | ||
while (a.Next(leftRight) && leftRight->GetRight() < p_left) { | ||
MxSegment* segment; | ||
while (a.Next(segment) && segment->GetMax() < p_min) { | ||
; | ||
} | ||
|
||
if (!a.HasMatch()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you change this to if (a.HasMatch())
and reverse the if
/else
blocks, it matches the beta better. No apparent effect on lego1 though.
Looks good! I haven't found any regressions so far. Some more beta addrs here if you want to add them. Not all should be comment annotations, I just did it that way for simplicity:
|
This adapts our
MxRegion
implementation to the recently surfacedMxRegion.h
file. It gives proper names to entities and merges theMxRegionCursor
and everything fromMxRegionList
intoMxRegion
.We can wait until we have the "entropy" detection in place to verify nothing breaks, although in this case the entropy seems relatively low.