chore(sourcemap): convert inputSourceMap to plain js object #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babel/core recently made a change where the sourcemap is no longer a plain js object, but instead is a class SourceMap. This breaks when the coverage data gets passed into valueToNode by istanbul-lib-instrument because the coverage data is no longer entirely plain json objects (this.cov.toJSON() just returns the data and doesn't do any conversion). In this PR we are checking if the input sourcemap is a plain js object, and converting it if it is not.
|
@thebanjomatic I think this problem is better fixed here, if I'm following: The only thing blocking #662 from landing is that someone needs to write a test. I would happy accept a PR for a test, if you'd like to contribute (you can branch from #662). |
|
Should we close this since it was fixed upstream? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/core recently made a change where the sourcemap is no longer a plain js
object, but instead is a class SourceMap. This breaks when the coverage data
gets passed into valueToNode by istanbul-lib-instrument because the coverage
data is no longer entirely plain json objects (this.cov.toJSON() just returns
the data and doesn't do any conversion).
In this PR we are checking if the input sourcemap is a plain js object, and
converting it if it is not.
Note that this does seem like the more appropriate place to make the fix since it
is istanbul that has the requirement that the coverage data is a plain javascript object
and the patch applied here babel/babel#14283 is more of a
temporary workaround.
istanbuljs/istanbuljs#672