Update rimraf and glob #1565
Open
Update rimraf and glob #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielbeeke thank you for the PR, things seem to mostly be working, but
Anything jump out at you, for what might be causing this? |
|
It seems glob argument needs to be added for windows only. See: isaacs/rimraf#249 |
|
Hi @bcoe would it be possible to run the CI again? |
|
Is there another maintainer that can help with the CI? It just needs to be triggered I think. |
|
Hey @danielbeeke still getting quite a few "not ok" errors with Windows. If you can get it green I'll bump the deps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a pull request for updating the glob and rimraf version.
I am trying to remove the deprecation warnings.
Sorry for the previous pull request that one is only for glob.