envoy file provider support omit_empty_values
#3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
zirain
added
the
release-notes-none
|
/test release-notes |
zirain
changed the title
omit_empty_values
hzxuzhonghu
reviewed
Feb 5, 2025
| // Optional. If set to true, when command operators are evaluated to null, | ||
| // For text format, the output of the empty operator is changed from “-“ to an empty string. | ||
| // For json format, the keys with null values are omitted in the output structure. | ||
| bool omit_empty_values = 3; |
There was a problem hiding this comment.
by default is it is empty, isn't it difficult to distinguish which field is empty?
There was a problem hiding this comment.
for text, yes.
but it's useful for json.
There was a problem hiding this comment.
So can we only make it work for json
There was a problem hiding this comment.
I think it's fine to give user the option, instead of make an exception.
User can use customized separator, e.g. [%CEL(xxxxxx)%].
hzxuzhonghu
approved these changes
Feb 12, 2025
istio-testing
added
the
needs-rebase
zirain
force-pushed
the
accesslog/omit_empty_values
branch
from
a307350 to
600974e
Compare
istio-testing
removed
the
needs-rebase
|
kindly ping @istio/technical-oversight-committee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: istio/istio#54930