add retry host predicate api #3432
Merged
+162
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <[email protected]>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/XS
hzxuzhonghu
reviewed
Feb 5, 2025
|
|
||
| // Flag to specify whether the retries should ignore previously tried hosts during retry. | ||
| // Defaults to true. | ||
| google.protobuf.BoolValue retry_ignore_previous_hosts = 5; |
There was a problem hiding this comment.
how about retry_previous_hosts, and make it false by default
There was a problem hiding this comment.
We can. It seems little confusing to me. But fine either way
istio-testing
added
the
needs-rebase
|
@istio/technical-oversight-committee can you PTAL? |
|
Looks ok to me. Can you fix the merge conflicts? |
istio-testing
removed
the
needs-rebase
|
Done |
ramaraochavali
added
the
release-notes-none
|
/test release-notes |
keithmattix
approved these changes
Feb 22, 2025
zirain
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed retry host predicate via this PR istio/istio@3727b57 to fix a bug that is breaking consistent hash on retry. But there are some use cases which rely on this behaviour. So this PR is to propose an API for it with default to current behaviour and people can change if needed. This is similar to other retry plugin i.e. retryRemoteLocaliities.