Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added traffic.istio.io/ingress-public-address annotation #3438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added traffic.istio.io/ingress-public-address annotation #3438

wants to merge 1 commit into from
+48 −0

Conversation

schurcht
Copy link

Adding a service annotation that allows users to override the IP Istio will use to reach out to gateways.
This enables you to use a private load balancer with a public IP that DNATs to it.

@schurcht schurcht requested a review from a team as a code owner February 10, 2025 22:44
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Feb 10, 2025
@istio-testing
Copy link
Collaborator

Hi @schurcht. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

howardjohn
howardjohn reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this actually intended to be used by?

@keithmattix
Copy link
Contributor

keithmattix commented Feb 10, 2025 •
edited
Loading

I strongly suspect this is with respect to istio/istio#55041

@schurcht
Copy link
Author

What is this actually intended to be used by?

istio/istio#55041

@hzxuzhonghu
Copy link
Member

not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@remiminnebo remiminnebo remiminnebo approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@schurcht @istio-testing @keithmattix @hzxuzhonghu @howardjohn @remiminnebo