Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add waypoint context to envoyfilter #3442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dprotaso
Copy link

@dprotaso dprotaso commented Feb 18, 2025

Part of istio/istio#43720

/assign @howardjohn

@dprotaso dprotaso requested a review from a team as a code owner February 18, 2025 15:38
@istio-policy-bot
Copy link

😊 Welcome @dprotaso! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Feb 18, 2025
@istio-testing
Copy link
Collaborator

Hi @dprotaso. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are to implement EnvoyFilter on waypoint I definitely think this is a step in the right direction. However, I don't think we yet have consensus that it is something that is desired at all. We probably would need to settle that before moving forward

@keithmattix
Copy link
Contributor

I added my thoughts here: istio/istio#55149 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants