-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trending_enabled
and search_enabled
params added
#4674
base: master
Are you sure you want to change the base?
Conversation
Code formatting issues will be fixed soon. |
If we are going to allow every specific pages to be disabled, we might as well use an array for that like:
|
Great suggestion. Do you recommend I implement it in this GitHub Pull Request or in a separate one? |
Would prefer in this one but we would need to keep compatibility with existing popular_enabled parameter. |
Understood, that works. |
@SamantazFox advice on my comment please: #4674 (comment) |
Yes, I second that! However, it will be a breaking change (will go with the next major version release). @NorkzYT Though, why do you want to disable search? For the trending feed, I can understand that you may not want random crap in your home page, but why search? |
My plan is to enable Invidious admins to control which features are accessible to users. This is particularly important for families/my family with young children who prefer YouTube over YouTube Kids. I found that existing tools lacked the ability to give admins such granular control over user features, thus I decided to contribute to Invidious by developing these admin control features. For instance, in my case, I want to restrict access for some users that only very young children use to only allow certain YouTube channels that are pre-approved and subscribed to their user account. By disabling features like search, trending, and popular, I can ensure that children only interact with videos from these subscribed channels and playlists, thereby preventing exposure to unsuitable and overage content. Additionally, I propose adding a search bar specifically for subscriptions and playlists. This would allow users to quickly find videos within these predefined categories without the need to navigate through entire channels or playlists, thus saving time and ensuring a safer viewing experience. I know that a tool called TubeArchivist has a search feature for videos that have already been downloaded. However, I am switching from TubeArchivist to Invidious because I no longer want to host 5TB of downloaded YouTube videos, especially as the library keeps growing. |
I will start working on this to complete as soon as I can. |
Complete. Someone please test as the only issue I know is the Invidious docker container becoming
|
The health check is hitting the trending endpoint
Which you have disabled, so it is natural for it to appear unhealthy |
Ah, thank you for the explanation. Much appreciated. I went right by it and did not notice. |
Co-authored-by: Samantaz Fox <[email protected]>
Co-authored-by: Samantaz Fox <[email protected]>
Thank you for the info. Suggestions have been added and completed. |
This pull request contains two new config parameters,
trending_enabled
andsearch_enabled
.These parameters allow administrators to selectively enable or disable the trending and search functionalities within their Invidious instance. This was done with the motive to provide greater control over the feature set exposed to users.