fix(layout): sidebars partly hidden if content too tall #1574
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
reviewed
Nov 9, 2024
| @@ -184,7 +184,7 @@ a { | |||
| box-sizing: border-box; | |||
| padding: $topSpacing 2rem 2rem 2rem; | |||
| display: flex; | |||
| height: 100vh; | |||
| min-height: 100vh; | |||
There was a problem hiding this comment.
hmm, this would make side panel scrollable past vh
Screen.Recording.2024-11-09.at.00.38.09.mov
in this case I have sidebar set to display: grid. Not sure if this affects anything.
There was a problem hiding this comment.
I have a suspicion that it is caused by not setting a height. I'll investigate later today.
There was a problem hiding this comment.
no rush. Thanks for the prompt update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1567