Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating readme on addHandler for hooks #1116

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Aug 21, 2024

fixes #1114

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
updating readme on addHandler for hooks for #1114

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@75705db). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #1116   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        15           
  Lines           ?        67           
  Branches        ?         0           
========================================
  Hits            ?        67           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray merged commit 5345e05 into main Aug 21, 2024
7 checks passed
@jaredwray jaredwray deleted the updating-readme-on-addHandler-for-hooks branch August 21, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V5.0.0 Bug in the example code for hooks in keyv/packages/keyv /README.md
1 participant