[better_errors] Continue adding debug info to Jaxprs (step 4) #26384
+201
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
debug_info_jaxpr_4
branch
from
d789758 to
d709f32
Compare
This follows after jax-ml#26078, jax-ml#26313, jax-ml#26348, adding `debug_info` to more calls to `lu.wrap_init`. As part of this I have changed the primitive `custom_transpose` to take the `transpose` parameter as a `lu.WrappedFun`, which carries debug info. Previously, this was a `Callable`. These changes ensure that all the `lu.wrap_init` and `Jaxpr` are called with debug_info in the `api_test.py:CustomTransposeTest`.
gnecula
force-pushed
the
debug_info_jaxpr_4
branch
from
d709f32 to
3150109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows after #26078, #26313, #26348, adding
debug_infoto more calls tolu.wrap_init.As part of this I have changed the primitive
custom_transposeto take thetransposeparameter as alu.WrappedFun, which carries debug info. Previously, this was aCallable.These changes ensure that all the
lu.wrap_initandJaxprare called with debug_info in theapi_test.py:CustomTransposeTest.