add support for everyone option to is_active_for_user (#491)

jazzband · Nov 24, 2023 · 21d7fad · 21d7fad
1 parent be05c2c
commit 21d7fad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/waffle/models.py b/waffle/models.py
@@ -230,6 +230,9 @@ def get_flush_keys(self, flush_keys: list[str] | None = None) -> list[str]:
         return flush_keys
 
     def is_active_for_user(self, user: AbstractBaseUser) -> bool | None:
+        if self.everyone:
+            return True
+
         if self.authenticated and user.is_authenticated:
             return True
 

diff --git a/waffle/tests/test_models.py b/waffle/tests/test_models.py
@@ -5,6 +5,7 @@
     get_waffle_sample_model,
     get_waffle_switch_model,
 )
+from django.contrib.auth.models import User
 
 
 class ModelsTests(TestCase):
@@ -30,3 +31,8 @@ def test_natural_keys(self):
     def test_flag_is_not_active_for_none_requests(self):
         flag = get_waffle_flag_model().objects.create(name='test-flag')
         self.assertEqual(flag.is_active(None), False)
+
+    def test_is_active_for_user_when_everyone_is_active(self):
+        flag = get_waffle_flag_model().objects.create(name='test-flag')
+        flag.everyone = True
+        self.assertEqual(flag.is_active_for_user(User()), True)