Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat modules for tomllib and importlib.metadata #2108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Jun 26, 2024

The conditional backports increased, thus I added two compatibility modules.

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@chrysle chrysle added refactor Refactoring code dependency Related to a dependency skip-changelog Avoid listing in changelog labels Jun 26, 2024
@WhyNotHugo
Copy link
Member

Can you rebase this? The CI failures seem unrelated.

@chrysle
Copy link
Contributor Author

chrysle commented Aug 14, 2024

The CI failures seem unrelated.

They are, but tests are also failing on main. We're struggling to fix them for quite a while now. #2106, which still awaits reponse, partly succeeds in doing that, but then there're still the broken Windows tests and I hate Windows feel unable to reproduce the failure.

@webknjaz
Copy link
Member

webknjaz commented Sep 5, 2024

@chrysle I've responded there since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to a dependency refactor Refactoring code skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants