Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dashboard user pages to use TS SDK #6403

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate dashboard user pages to use TS SDK #6403

wants to merge 4 commits into from

Conversation

viown
Copy link
Member

@viown viown commented Dec 20, 2024

Some dashboard user pages will be migrated when there are no active PRs on them.

Changes

  • Migrate the react dashboard user pages to use React Query + TS SDK
  • Properly unmount events to avoid issues with strict mode and react query.

Issues

@viown viown added the cleanup Cleanup of legacy code or code smells label Dec 20, 2024
@viown viown requested a review from a team as a code owner December 20, 2024 19:30
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 20, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 8164b46
Status ✅ Deployed!
Preview URL https://0f614ba5.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

github-actions[bot]
github-actions bot requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/apps/dashboard/routes/users/profile.tsx Outdated Show resolved Hide resolved
src/apps/stable/routes/user/userprofile.tsx Outdated Show resolved Hide resolved
src/components/dashboard/users/UserPasswordForm.tsx Outdated Show resolved Hide resolved
@viown viown changed the title Migrate user pages to use TS SDK Migrate dashboard user pages to use TS SDK Dec 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells merge conflict Conflicts prevent merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viown @jellyfin-bot