[JENKINS-73713] Do not filter params for completed run #9681
Conversation
If the Run has already completed there is no need to filter the parameters. This avoids unnecessary warnings about skipped parameters when getting environment for runs that have already finished.
|
Why is the behavior you're describing in Jira a bug? Wouldn't having a different environment for polling than the reference run be the bug? The warning is annoying and can probably be downgraded to FINE or so. We just need these messages to be very visible when we first introduce them so admins can have an idea why behavior changed, but it's been several years now. |
This is not about having different environment for polling. In my understanding the problem is that we combine the current environment from the Project into the historical Run. The warning will be raised for the historical (completed) run. In my understanding the environment for a historical run should be whatever it was at the time when the run was completed (i.e. no need to filter anything). E.g. in the reproduction instruction:
The polling will raise the warning when reading the environment for the previous, completed run. Why should we warn the user about environment for a build that has already been completed? |
|
P.S. I'm against downgrading to FINE. Users need to know when parameters get dropped and the warning is very useful in context of currently active Run but for historical Run it simply makes no sense |
If the Run has already completed there is no need to filter the parameters. This avoids unnecessary warnings about skipped parameters when getting environment for runs that have already finished.
See JENKINS-73713.
Testing done
Tested manually and regression run.
Proposed changelog entries
Proposed upgrade guidelines
N/A