Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73437] Fix build history no automatic line wrapping #9693

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

ridemountainpig
Copy link
Contributor

@ridemountainpig ridemountainpig commented Sep 5, 2024

See JENKINS-73437.

Testing done

Before:
CleanShot 2024-09-05 at 14 52 56

After
CleanShot 2024-09-05 at 14 55 13

Proposed changelog entries

  • Wrap long lines in the build history.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Sep 12, 2024
@timja timja requested a review from a team September 12, 2024 08:05
@Kevin-CB Kevin-CB added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Sep 17, 2024
@janfaracik
Copy link
Contributor

image

Tested locally, LGTM. Thanks!

@daniel-beck
Copy link
Member

According to the spec, break-word is deprecated in favor of word-break: normal and overflow-wrap: anywhere. Is there a reason (e.g., compatibility) we're not using those?

@ridemountainpig
Copy link
Contributor Author

According to the spec, break-word is deprecated in favor of word-break: normal and overflow-wrap: anywhere. Is there a reason (e.g., compatibility) we're not using those?

Sorry, I didn't notice that break-word had been deprecated. I have changed it to word-break: normal and overflow-wrap: anywhere, and I tested it locally with success.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after the pending security release, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 25, 2024
@MarkEWaite MarkEWaite merged commit 9036086 into jenkinsci:master Oct 2, 2024
16 checks passed
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Oct 5, 2024
…ci#9693)

* Fix build history no automatic line wrapping

* Update _job.scss

(cherry picked from commit 9036086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants