feat: support ESLint 8.x #903

MichaelDeBoey · 2021-09-20T09:22:17Z

ESLint v8.0.0 is released 🎉

Dependencies should be compatible with ESLint 8 too before we can merge this one:

@typescript-eslint/experimental-utils (Support for ESLint v8 typescript-eslint/typescript-eslint#3738)

devDependency compatibility with ESLint 8:

Supersedes #882

Closes #881

src/rules/no-done-callback.ts

SimenB

Some changes causes unnecessarily big diffs, would be nice to avoid them 🙂

.github/workflows/nodejs.yml

package.json

src/rules/__tests__/utils.test.ts

src/rules/prefer-expect-assertions.ts

src/rules/prefer-strict-equal.ts

.eslintrc.js

SimenB · 2021-09-22T07:04:34Z

a9ae1de should fix the failing run, so this should be rebased 🙂

SimenB · 2021-10-10T09:09:40Z

#928

SimenB · 2021-10-10T09:33:57Z

OK, our major is out: https://github.com/jest-community/eslint-plugin-jest/releases/tag/v25.0.0

My assumption is that landing this is a semver minor when @typescript-eslint/experimental-utils makes a release 🙂

(if not, numbers are cheap)

SimenB · 2021-10-11T18:37:25Z

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0

SimenB · 2021-10-11T21:54:58Z

I've updated @typescript-eslint/* in #941 and #942. For some reason testing with ESLint v8 still fails though (see #940), but at least for people who ignore peer dep warnings should be unblocked

MichaelDeBoey · 2021-10-13T20:53:48Z

@SimenB Tests are failing but I can't figure out why, can you point me into the right direction so we can merge this one asap?

G-Rath · 2021-10-13T20:58:59Z

@MichaelDeBoey the error about @eslint/eslintrc/universal is because it uses package exports which isn't supported by jest - this is the fix.

The error about context.getPhysicalFilename is because that was added in ESLint v7.28, which eslint-plugin-prettier must now require (aka they dropped support for v6 & co) - we should be able to disable the rule for that run 🤔 (I think the easiest way of doing that is probably to have an env variable in our config that sets it to "off" if present)

MichaelDeBoey · 2021-10-13T21:45:36Z

@G-Rath The prettier errors seem fixed now, but seems like we missed something

G-Rath · 2021-10-13T21:51:48Z

@MichaelDeBoey looks like eslint-plugin-eslint-plugin is having troubles with at least v6 of eslint.

The unbound-method errors is something I need to look into when I'm not working, because that is an extension of the existing rule shipped in @typescript-eslint, and so it's tests are copied from that + a couple of our own to test our extension.

Since I probably won't be able to look into this properly until the weekend, and because I think it might be the answer, if you want to look into adjusting our tests to skip running unbound-method on v8 I think that would be good (I'm half expecting it might be easiest for us to have two sets of the tests: ones for <v8/=v8/>=v5, depending on what is actually causing the errors.)

SimenB · 2021-10-14T06:50:21Z

@MichaelDeBoey the error about @eslint/eslintrc/universal is because it uses package exports which isn't supported by jest - this is the fix.

Note that config workaround is not needed with 8.0.1 https://github.com/eslint/eslint/releases/tag/v8.0.1

SimenB · 2021-10-14T06:52:01Z

.eslintrc.js

@@ -28,12 +30,18 @@ module.exports = {
    es6: true,
  },
  rules: {
+    // eslint-plugin-prettier removed ESLint v6 support
+    ...(semver.gte(version, '7.28.0') ? {} : { 'prettier/prettier': 'off' }),


just keep using eslint-plugin-prettier@3, no reason to upgrade it

G-Rath · 2021-10-14T19:27:05Z

package.json

@@ -60,6 +60,9 @@
    "projects": [
      {
        "displayName": "test",
+        "moduleNameMapper": {
+          "@eslint/eslintrc/universal": "@eslint/eslintrc/dist/eslintrc-universal.cjs"


Suggested change

"@eslint/eslintrc/universal": "@eslint/eslintrc/dist/eslintrc-universal.cjs"

"eslint/use-at-your-own-risk": "eslint/lib/unsupported-api.js"

This is whats giving unbound-method trouble

(you can replace the existing map since we'll update to v8.0.1)

SimenB · 2021-10-14T19:37:51Z

I just landed the other PR as this one has a bunch of changes we don't need.

Thanks for your help here @MichaelDeBoey!

github-actions · 2021-10-14T19:39:12Z

🎉 This issue has been resolved in version 25.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

MichaelDeBoey mentioned this pull request Sep 20, 2021

feat: support ESLint 8.x #882

Closed

MichaelDeBoey commented Sep 20, 2021

View reviewed changes

src/rules/no-done-callback.ts Outdated Show resolved Hide resolved

SimenB requested changes Sep 20, 2021

View reviewed changes

MichaelDeBoey mentioned this pull request Sep 20, 2021

chore(ci): specify only majors for GH Actions #904

Merged

SimenB mentioned this pull request Sep 20, 2021

Release v25 #905

Merged

2 tasks

SimenB reviewed Sep 20, 2021

View reviewed changes

.eslintrc.js Show resolved Hide resolved

SimenB deleted the branch jest-community:main October 10, 2021 09:26

SimenB closed this Oct 10, 2021

SimenB reopened this Oct 10, 2021

SimenB changed the base branch from next to main October 10, 2021 09:27

SimenB mentioned this pull request Oct 10, 2021

chore(deps): update dependency eslint to v8 #928

Closed

1 task

gwyneplaine mentioned this pull request Oct 12, 2021

Update dependency eslint to v8 keystonejs/keystone#6769

Merged

1 task

targos mentioned this pull request Oct 12, 2021

chore: release 6.0.0 cheminfo/eslint-config#16

Merged

MichaelDeBoey force-pushed the eslint-8 branch from 6787dcb to 554c000 Compare October 12, 2021 09:18

MichaelDeBoey force-pushed the eslint-8 branch 2 times, most recently from dae2f55 to db36086 Compare October 12, 2021 09:54

MichaelDeBoey marked this pull request as ready for review October 12, 2021 09:55

MichaelDeBoey requested a review from SimenB October 12, 2021 09:55

MichaelDeBoey force-pushed the eslint-8 branch 4 times, most recently from 3a7607a to be5bb93 Compare October 12, 2021 10:06

kimromi mentioned this pull request Oct 12, 2021

Let's support eslint v8 moneyforward/eslint-config-moneyforward#14

Closed

branchvincent mentioned this pull request Oct 13, 2021

chore(deps-dev): bump eslint from 7.32.0 to 8.0.0 mgagliardo91/postgraphile-federation-plugin#3

Merged

MichaelDeBoey force-pushed the eslint-8 branch 2 times, most recently from fbd2cfb to 9a46527 Compare October 13, 2021 18:46

MichaelDeBoey force-pushed the eslint-8 branch from 9a46527 to 747d36e Compare October 13, 2021 21:38

feat: support ESLint 8.x

9454201

MichaelDeBoey force-pushed the eslint-8 branch from 747d36e to 9454201 Compare October 13, 2021 21:41

SimenB reviewed Oct 14, 2021

View reviewed changes

G-Rath reviewed Oct 14, 2021

View reviewed changes

SimenB mentioned this pull request Oct 14, 2021

feat: support eslint@8 #940

Merged

4 tasks

SimenB closed this in #940 Oct 14, 2021

github-actions bot added the released label Oct 14, 2021

Belco90 mentioned this pull request Oct 17, 2021

chore(dev-dependencies): upgrade ESLint and plugins to v8 testing-library/eslint-plugin-testing-library#499

Closed

66 tasks

MichaelDeBoey deleted the eslint-8 branch October 27, 2021 22:51

ti10le mentioned this pull request Oct 28, 2021

chore(deps): update dependency eslint to v8 marigold-ui/marigold#1434

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support ESLint 8.x #903

feat: support ESLint 8.x #903

MichaelDeBoey commented Sep 20, 2021 •

edited

Loading

SimenB left a comment

SimenB commented Sep 22, 2021

SimenB commented Oct 10, 2021

SimenB commented Oct 10, 2021

SimenB commented Oct 11, 2021

SimenB commented Oct 11, 2021

MichaelDeBoey commented Oct 13, 2021

G-Rath commented Oct 13, 2021 •

edited

Loading

MichaelDeBoey commented Oct 13, 2021

G-Rath commented Oct 13, 2021

SimenB commented Oct 14, 2021

SimenB Oct 14, 2021

G-Rath Oct 14, 2021

SimenB commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

	"@eslint/eslintrc/universal": "@eslint/eslintrc/dist/eslintrc-universal.cjs"
	"eslint/use-at-your-own-risk": "eslint/lib/unsupported-api.js"

feat: support ESLint 8.x #903

feat: support ESLint 8.x #903

Conversation

MichaelDeBoey commented Sep 20, 2021 • edited Loading

SimenB left a comment

Choose a reason for hiding this comment

SimenB commented Sep 22, 2021

SimenB commented Oct 10, 2021

SimenB commented Oct 10, 2021

SimenB commented Oct 11, 2021

SimenB commented Oct 11, 2021

MichaelDeBoey commented Oct 13, 2021

G-Rath commented Oct 13, 2021 • edited Loading

MichaelDeBoey commented Oct 13, 2021

G-Rath commented Oct 13, 2021

SimenB commented Oct 14, 2021

SimenB Oct 14, 2021

Choose a reason for hiding this comment

G-Rath Oct 14, 2021

Choose a reason for hiding this comment

SimenB commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

MichaelDeBoey commented Sep 20, 2021 •

edited

Loading

G-Rath commented Oct 13, 2021 •

edited

Loading