Fixes #12289 - Improve ConcurrentPool concurrency. #12290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A call to `sweep()`, although protected by the lock for concurrent calls to `reserve()`, may be concurrent with `remove(Entry)`. `remove(Entry)` in turn calls `entries.remove(Object)`, so that the concurrent iteration in `sweep()` over `entries` fails with an `ArrayIndexOutOfBoundsException`. Now using the bulk `entries.removeIf(Predicate)` method in `sweep()`, so that sweeping is atomic with respect to `entries.remove(Object)`. Signed-off-by: Simone Bordet <[email protected]>
sbordet
added
the
Sponsored
… that may be concurrent with removals. Signed-off-by: Simone Bordet <[email protected]>
lorban
requested changes
Sep 20, 2024
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Sep 20, 2024
gregw
reviewed
Sep 23, 2024
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/ContextHandler.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to
sweep(), although protected by the lock for concurrent calls toreserve(), may be concurrent withremove(Entry).remove(Entry)in turn callsentries.remove(Object), so that the concurrent iteration insweep()overentriesfails with anArrayIndexOutOfBoundsException.Now using the bulk
entries.removeIf(Predicate)method insweep(), so that sweeping is atomic with respect toentries.remove(Object).