Use Chrome commands instead of custom key commands #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Alert the user if they use it on a chrome:// url. Closes #9 - Alert the user if they use it on a file:/// url. Closes #7 - Set the default chrome key command to Shift+Ctrl+E. Closes #8 - General code cleanup and linting This commit also makes the box size save properly if the user uses the key command to close the editor because of the way that the browser_action commands work. Per #1
jhubert
added a commit
that referenced
this pull request
Dec 2, 2014
Use Chrome commands instead of custom key commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also makes the box size save properly if the user uses the key
command to close the editor because of the way that the browser_action
commands work. Per #1