Add optional client parameter to UploadsDocument::upload()

jlevers · Feb 16, 2025 · a1896a7 · a1896a7
1 parent 4190427
commit a1896a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -538,7 +538,7 @@ $createFeedResponse = $feedsApi->createFeed($createFeedSpec);
 $feedId = $createFeedResponse->dto()->feedId;
 ```
 
-If you are working with feed documents that are too large to fit in memory, you can pass anything that Guzzle can turn into a stream into `FeedDocument::upload()` instead of a string.
+If you are working with feed documents that are too large to fit in memory, you can pass anything that Guzzle can turn into a stream into `FeedDocument::upload()` instead of a string. `FeedDocument::upload()` also has an optional `$client` parameter, for passing custom Guzzle clients.
 
 
 ## Downloading a feed result document

diff --git a/src/Traits/UploadsDocument.php b/src/Traits/UploadsDocument.php
@@ -15,9 +15,10 @@ trait UploadsDocument
     public function upload(
         string $feedType,
         string|StreamInterface|callable|Iterator $data,
-        ?string $charset = null
+        ?string $charset = null,
+        ?Client $client = null
     ): void {
-        $client = new Client;
+        $client = $client ?? new Client;
         $response = $client->put($this->url, [
             RequestOptions::HEADERS => [
                 'Content-Type' => static::getContentType($feedType, $charset),