Remove Shipment Address required values #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we would have a separate Address types for requests and responses, but given FBA Inbound v0 is deprecated to be removed at the end of the year, I don't think it's worth implementing |
|
I've added an additional field in the GetShipments call that's marked as required, but missing in response from Amazon |
|
Is the |
Data fetched from Amazon for shipments can be missing values. This results in deserialisation errors when Amazon returns data with those fields missing. Fixes jlevers#703
Responses from Amazon are missing this column
dpash
force-pushed
the
make-shipments-address-not-required
branch
from
1a2de50
to
2a74e60
Compare
|
I don't have enough data to say for certain yet. I've updated the PR to resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data fetched from Amazon for shipments can be missing values. This results in deserialisation errors when Amazon returns data with those fields missing.
Fixes #703