Deserializes.php broke if the type is an DateTimeInterface due to only checking for classes and not interfaces #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DateTimeInterface, so that the serialization process triggered an exception.
KhorneHoly
changed the title
|
Couple minor comments, but looks good! Thanks for catching this. The reason for the Zulu format comment is that we changed the format in #699, too. |
Hi, thanks for the reply. You said something about minor comments, but I wasn't able to find anything. Am I missing something? Hit me up if there's need to change. |
jlevers
reviewed
Jun 17, 2024
|
Whoops, sorry...I hadn't clicked "Submit review." Should be visible now. |
No worries, I've pushed a new commit with the respective changes. Also updated the exception message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserialization broke while creating the DTO from the SellingPartnerApi\Seller\ReportsV20210630\Responses\Report class, since the dates all are of the type DateTimeInterface.